feat: allow moving YouTube live chat below in theater mode (#3545)#3585
Open
suryaprakash0010 wants to merge 18 commits intocode-charity:masterfrom
Open
feat: allow moving YouTube live chat below in theater mode (#3545)#3585suryaprakash0010 wants to merge 18 commits intocode-charity:masterfrom
suryaprakash0010 wants to merge 18 commits intocode-charity:masterfrom
Conversation
Member
|
thank you! @suryaprakash0010 the observer could be wrapped conditionally
|
…-heatmap Feat: Implement Smart Speed feature using YouTube heatmap (code-charity#1463)
…e-charity#3460) The `playbackSpeed()` function was returning raw `video.playbackRate` values after setting speed, leading to IEEE 754 floating-point artifacts like "1.1500000000000001x" in the speed indicator. The read path (line 111) already rounds with `Number(x.toFixed(2))`, but the write-and-readback path (lines 123, 126) did not. When callers concatenated the raw return value with 'x' (e.g. `showStatus(speed + 'x')`), the result was a string that bypassed `showStatus()`'s `typeof number` → `toFixed(2)` guard. Fix: apply the same `Number(x.toFixed(2))` rounding pattern to the readback values at lines 123 and 126, consistent with line 111. Co-authored-by: Cursor <cursoragent@cursor.com>
…-embed-ui Fix YouTube embed UI missing on old Reddit (fixes code-charity#3601)
…ator-floating-point-3460 fix: round playback speed readback to fix floating-point display (code-charity#3460)
we can still - make the music / or education category exclusions apply here. - combine speed, with the speed if 'forced / permanent speed' above (or at least make the two toggles mutually exclusive in the settings.)
Removed duplicate 'Copy Transcript' entry from messages.
Removed duplicate 'Buttons' entry in messages.json.
…-scroll-bug Fix Shorts scrolling freeze and looping issue (code-charity#3598)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature: Move Live Chat Below Theater Mode
🎯 Issue Summary
Implements #3545 - Add option to move live chat below the player in theater mode, allowing users to use theater mode while still having access to live chat.
🔍 Problem Statement
YouTube's theater mode hides the live chat sidebar, making it impossible to watch live streams in theater mode while following the chat. Users requested the ability to move live chat below the player, similar to how comments can be repositioned.
🛠️ Solution Overview
Core Implementation
ytd-watch-flexy[theater]attributeKey Features
📁 Files Changed
📝
js&css\web-accessible\www.youtube.com\appearance.jslivechatBelowTheater()function for main repositioning logiclivechatTheaterModeObserver()function for automatic theater mode detection📝
js&css\web-accessible\functions.jsvideoPageUpdate()for proper initialization📝
js&css\web-accessible\core.jslivechatandlivechat_below_theatersettings🧪
test-live-chat-below-theater.js(New)🔄 Technical Implementation
DOM Structure
ytd-live-chat-frame#chatytd-watch-flexy[theater]attribute#below(below player area)#secondary-inner(sidebar)Positioning Logic
Observer Pattern
✅ Verification
Automated Testing
Manual Testing Steps
Test Coverage
📊 Impact Assessment
Files Modified: 3 core files + 1 test file
Lines Added: ~150 lines
Breaking Changes: None
Performance: Minimal impact (single observer)
Compatibility: Works with existing live chat features
🎉 User Benefits
🔧 Configuration
Users can enable this feature through:
📝 Notes